Shooting is attitude and alignment. Start at the foul line, everything else falls in place.
The big toe of the shooting foot is exactly on the nail, if you are in line you won't miss left or right. If the shooting foot points to the left, you have to fly your elbow or it will hit your hip. The index finger is on the valve stem. The target is right over the front of the rim, eyes are fixed on the target, don't watch the ball. Hold the follow-through, don't snap it back.
Very little changes on a jump shot, and nothing changes if you jump on a foul shot (he comes up on his toes).
For a simple drill, from an open stance with the shooting foot behind the pivot foot at about 45 degrees, spin a pass, hand position in the middle of the ball, pivot (step with the shooting foot), repeat, there is no shot.
Shooting off a pass, the shooting foot is back, catch, pivot and shoot, you can keep moving backwards to behind the arc. Get your hand in the middle of the ball on the catch. Once you get the ball to the shooting pocket, the hand must be as close to centre as it can.
Shooting off the dribble, now you have to catch and pivot twice. Catch and pivot, shot fake, to go right with one dribble, the footwork for a right-hander is right-left-right. Going left, you want to pivot on the strong left foot, the footwork is again right-left-right, it's a very quick shot and it's the same shot. The pivot is the same going right, left, and on a spot-up. If you use right-left footwork for a crossover pull-up, the shot is much flatter and the shooting side doesn't come through.
Players should pivot as much as possible off their non-shooting leg.